MVP: Setup of the latest otp-react-redux app implementation #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first MVP for the new web-client application based on the latest otp-react-redux app.
In order to maintain a direct link with the upstream application, we've integrated it as a git submodule that can be pulled frequently. This is a workaround around the fact that the library can't be included directly using standard package system such as npm/yarn.
The downside to this approach is that the package.json and yarn.lock file have to be synchronized when the upstream version is updated.
A few files are duplicated within the odh-mentor-otp repository, in lib/app folder, such as
app.js
,main.js
andindex.js
. These are necessary to setup the react application and to have our own version of these files will allow us to override some configuration or select different components to be provided to the rest of the application.Setup
In order to test the application, it should be enough to pull the git submodule and run
yarn start
withn theweb-demo
folder.Configuration
We've setup a simple basic configuration for now, taking over a few of the parameters from the previous
journey
application and connecting to the test instances of pelias and OTP. Further work should still be done here to migrate previous configuration as possible and needed.